Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging's step values when multiple dataloaders are used during evaluation #12184

Merged
merged 21 commits into from
May 31, 2022
Merged

Fix logging's step values when multiple dataloaders are used during evaluation #12184

merged 21 commits into from
May 31, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Mar 2, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #11616

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @otaj @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @justusschock @ninginthecloud

@rohitgr7 rohitgr7 added bug Something isn't working logging Related to the `LoggerConnector` and `log()` loops Related to the Loop API labels Mar 2, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review March 2, 2022 16:21
@rohitgr7 rohitgr7 requested a review from carmocca March 2, 2022 18:35
@mergify mergify bot added the has conflicts label Mar 5, 2022
@rohitgr7 rohitgr7 self-assigned this Mar 21, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Mar 21, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Apr 26, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 10, 2022
carmocca
carmocca approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the deprecation here. It can be easily removed when cherry-picked into a bugfix release.

pytorch_lightning/loops/epoch/evaluation_epoch_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/evaluation_epoch_loop.py Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that lightning offers step level logging for validation/testing still baffles me today. Absolute insanity.
Anyway, thanks @rohitgr7 for working on this!

CHANGELOG.md Show resolved Hide resolved
@carmocca carmocca changed the title Fix logging on step level for eval mode Fixed logging's step values when multiple dataloaders are used during evaluation May 31, 2022
@carmocca carmocca disabled auto-merge May 31, 2022 19:59
@carmocca carmocca enabled auto-merge (squash) May 31, 2022 19:59
@carmocca carmocca disabled auto-merge May 31, 2022 19:59
@carmocca carmocca changed the title Fixed logging's step values when multiple dataloaders are used during evaluation Fix logging's step values when multiple dataloaders are used during evaluation May 31, 2022
@carmocca carmocca merged commit ba43882 into master May 31, 2022
@carmocca carmocca deleted the fix/eval_step_logging branch May 31, 2022 20:00
carmocca added a commit that referenced this pull request May 31, 2022
@rohitgr7 @justusschock @carmocca
Fix logging's step values when multiple dataloaders are used during e…
1ec73f9 
…valuation (#12184)

Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@rohitgr7 @justusschock
@carmocca @lexierule
Fix logging's step values when multiple dataloaders are used during e…
bd50b26 
…valuation (#12184)

Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@rohitgr7 rohitgr7

Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` loops Related to the Loop API ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6.x
Development

Successfully merging this pull request may close these issues.

Inconsistent step values when using multiple val/test dataloaders when logged on step-level
6 participants
@rohitgr7 @awaelchli @Borda @ethanwharris @carmocca @justusschock