Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPU] Support manually instantiating the poptorch.DataLoader #12116

Merged
merged 6 commits into from
Feb 28, 2022
Merged

[IPU] Support manually instantiating the poptorch.DataLoader #12116

merged 6 commits into from
Feb 28, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 25, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #10695

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @ninginthecloud

@carmocca carmocca added feature Is an improvement or enhancement data handling Generic data-related topic strategy: ipu (removed) labels Feb 25, 2022
@carmocca carmocca self-assigned this Feb 25, 2022
@carmocca carmocca added this to the 1.6 milestone Feb 25, 2022
@carmocca carmocca force-pushed the feat/ipu-return-poptorch-dataloader branch from a1c7cd1 to 30cc3b7 Compare February 25, 2022 13:49
@carmocca carmocca force-pushed the feat/ipu-return-poptorch-dataloader branch from ca9195e to a89bd49 Compare February 25, 2022 14:59
@carmocca carmocca marked this pull request as ready for review February 25, 2022 15:05
krshrimali
krshrimali approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but shouldn't block merging this PR. LGTM 🚀 (also, nice inline comments)

pytorch_lightning/strategies/ipu.py Show resolved Hide resolved
tests/accelerators/test_ipu.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 25, 2022
@carmocca carmocca enabled auto-merge (squash) February 28, 2022 00:53
tchaton
tchaton approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit 8fd17f2 into master Feb 28, 2022
@carmocca carmocca deleted the feat/ipu-return-poptorch-dataloader branch February 28, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krshrimali krshrimali krshrimali approved these changes

@akihironitta akihironitta akihironitta approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees

@carmocca carmocca

Labels
data handling Generic data-related topic feature Is an improvement or enhancement ready PRs ready to be merged strategy: ipu (removed)
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Support creating poptorch.DataLoader from within a LightningDataModule
6 participants
@carmocca @ananthsub @awaelchli @tchaton @krshrimali @akihironitta