Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AcceleratorConnector.has_ipu #12111

Merged
merged 3 commits into from
Feb 27, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Feb 25, 2022

What does this PR do?

Part of #11449: remove unused properties in accelerator_connector: has_ipu

AcceleratorConnector.has_ipu has no usage internally and was not meant to be a publish property.
It's removed in favor of using isinstance(self.accelerator, IPUAccelerator) and isinstance(self.strategy, IPUStrategy) directly

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [N/A] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • [N/A] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot added the ready PRs ready to be merged label Feb 26, 2022
@mergify mergify bot removed the has conflicts label Feb 27, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 27, 2022 12:59
@rohitgr7 rohitgr7 disabled auto-merge February 27, 2022 13:18
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 27, 2022 13:18
@rohitgr7 rohitgr7 changed the title Rremove AcceleratorConnector.has_ipu Remove AcceleratorConnector.has_ipu Feb 27, 2022
@rohitgr7 rohitgr7 merged commit b293233 into Lightning-AI:master Feb 27, 2022
@DuYicong515 DuYicong515 deleted the refactor/has_ipu branch February 28, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants