Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LightningCLI(auto_registry) #12108

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Add LightningCLI(auto_registry) #12108

merged 6 commits into from
Mar 8, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 25, 2022

What does this PR do?

Adds a flag that will automatically register all subclasses in memory for the registerable components.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa @tchaton

@carmocca carmocca added feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI labels Feb 25, 2022
@carmocca carmocca self-assigned this Feb 25, 2022
@carmocca
Copy link
Contributor Author

I'd like to get this merged as is and then switch the default to True in a follow-up as that will require a larger docs rewrite and that way it's easier to revert if necessary.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ! And let's make this True by default.

pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
@carmocca carmocca changed the title Add LightningCLI(register_automatically) Add LightningCLI(auto_registry) Feb 28, 2022
@carmocca carmocca enabled auto-merge (squash) February 28, 2022 10:32
@carmocca carmocca added this to the 1.6 milestone Feb 28, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 8, 2022
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@carmocca carmocca merged commit 8fa1569 into master Mar 8, 2022
@carmocca carmocca deleted the cli/register-automatically branch March 8, 2022 17:26
Borda pushed a commit to jerome-habana/lightning that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants