Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LightningModule.{un,}toggle_model when only 1 optimizer is used #12088

Merged
merged 7 commits into from
Feb 28, 2022

Conversation

CAIQT
Copy link
Contributor

@CAIQT CAIQT commented Feb 24, 2022

What does this PR do?

Fixes #12086.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can you add a simple test calling toggle and untoggle in the file tests/core/test_lightning_module.py?

You can mock the Trainer.

pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can you add a simple test calling toggle and untoggle in the file tests/core/test_lightning_module.py?

You can mock the Trainer.

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can you add a simple test calling toggle and untoggle in the file tests/core/test_lightning_module.py?

You can mock the Trainer.

@carmocca carmocca added the bug Something isn't working label Feb 24, 2022
@carmocca carmocca added this to the 1.5.x milestone Feb 24, 2022
@CAIQT CAIQT requested a review from carmocca February 26, 2022 16:02
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Feb 28, 2022
@carmocca carmocca enabled auto-merge (squash) February 28, 2022 11:31
@carmocca carmocca changed the title Make optimizers iterable in toggle_optimizer and untoggle_optimizer Fix LightningModule.{un,}toggle_model when only 1 optimizer is used Feb 28, 2022
@carmocca carmocca merged commit 01c31ae into Lightning-AI:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"object is not iterable" in lightning.toggle_optimizer when using single optimizer
5 participants