Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AccleratorConnector.device_type #12081

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Feb 24, 2022

What does this PR do?

Fixes #12077 (motivation and alternatives can be found in the issue)
Part of #11449: deprecate unused properties in accelerator_connector

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [N/A] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • [N/A] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @four4fish

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Carlos Mocholí <[email protected]>
@mergify mergify bot added the ready PRs ready to be merged label Feb 25, 2022
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion, if there is an alternate for the user to know the device type now, will be good to add in the issue/PR description. Shouldn't block merging this PR. LGTM!

@akihironitta akihironitta added this to the 1.6 milestone Feb 25, 2022
@akihironitta akihironitta enabled auto-merge (squash) February 25, 2022 09:09
@akihironitta akihironitta merged commit 6fcfd8c into Lightning-AI:master Feb 25, 2022
@DuYicong515
Copy link
Contributor Author

DuYicong515 commented Feb 25, 2022

Just a minor suggestion, if there is an alternate for the user to know the device type now, will be good to add in the issue/PR description. Shouldn't block merging this PR. LGTM!

That's a great suggestion! @krshrimali I'll add more contexts and info onto the issue and PR.

@krshrimali
Copy link
Contributor

Awesome, thank you so much for considering the suggestion! 💯 @DuYicong515

@DuYicong515 DuYicong515 deleted the refactor/device_type branch March 20, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AcceleratorConnector.device_type
7 participants