-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AccleratorConnector.device_type
#12081
Remove AccleratorConnector.device_type
#12081
Conversation
2c371d5
to
c3a968a
Compare
Co-authored-by: Carlos Mocholí <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion, if there is an alternate for the user to know the device type now, will be good to add in the issue/PR description. Shouldn't block merging this PR. LGTM!
That's a great suggestion! @krshrimali I'll add more contexts and info onto the issue and PR. |
Awesome, thank you so much for considering the suggestion! 💯 @DuYicong515 |
What does this PR do?
Fixes #12077 (motivation and alternatives can be found in the issue)
Part of #11449: deprecate unused properties in accelerator_connector
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
cc @four4fish