Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AcceleratorConnector.parallel_devices #12075

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Feb 23, 2022

What does this PR do?

Fixes #12074 (motivation and alternatives in the issue)
Part of #11449: remove unused properties in accelerator_connector.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@DuYicong515 DuYicong515 changed the title remove AcceleratorConnector.parallel_devices Remove AcceleratorConnector.parallel_devices Feb 23, 2022
@DuYicong515 DuYicong515 force-pushed the refactor/parallel_devices branch from 3a5351e to b290c3c Compare February 23, 2022 23:38
@DuYicong515
Copy link
Contributor Author

will hold-off until #12072 merged, as this change depending on that PR, while I don't have access to create a branch and change base branch.

@stale
Copy link

stale bot commented Mar 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Mar 13, 2022
@DuYicong515 DuYicong515 force-pushed the refactor/parallel_devices branch from b290c3c to a0306bd Compare March 18, 2022 22:36
@stale stale bot removed the won't fix This will not be worked on label Mar 18, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 24, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Mar 25, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 25, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 25, 2022
@ananthsub ananthsub enabled auto-merge (squash) March 25, 2022 01:24
@ananthsub ananthsub merged commit cfc9717 into Lightning-AI:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated AcceleratorConnector.parallel_devices
5 participants