Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Accelerator.parallel_device_ids and deprecate Trainer.data_parallel_device_ids #12072

Merged
merged 19 commits into from
Mar 23, 2022
Merged

Remove Accelerator.parallel_device_ids and deprecate Trainer.data_parallel_device_ids #12072

merged 19 commits into from
Mar 23, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Feb 23, 2022 •
edited
Loading

What does this PR do?

Fixes #12051 (Motivation and alternatives listed in the issue)
Part of #11449: deprecate unused properties in accelerator_connector

Does your PR introduce any breaking changes? If yes, please list them.

N/A

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [N/A] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • [N/A] Add labels and milestones (and optionally projects) to the PR so it can be classified

@DuYicong515 DuYicong515 changed the title remove Accelerator.parallel_device_ids and deprecate Trainer.data_par… Remove Accelerator.parallel_device_ids and deprecate Trainer.data_parallel_device_ids Feb 23, 2022
@DuYicong515 DuYicong515 force-pushed the deprecation/parallel_device_ids branch 2 times, most recently from c114f25 to 3c6669a Compare February 23, 2022 22:42
@DuYicong515 DuYicong515 marked this pull request as ready for review February 23, 2022 22:45
@DuYicong515 DuYicong515 mentioned this pull request Feb 23, 2022
Merged
12 tasks
carmocca
carmocca reviewed Feb 24, 2022
View reviewed changes
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Outdated Show resolved Hide resolved
@DuYicong515 DuYicong515 force-pushed the deprecation/parallel_device_ids branch from 3c6669a to da80c74 Compare February 24, 2022 20:04
four4fish
four4fish approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@four4fish four4fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@DuYicong515 DuYicong515 force-pushed the deprecation/parallel_device_ids branch from bc191af to a2fd454 Compare February 25, 2022 19:12
@mergify mergify bot removed the has conflicts label Feb 25, 2022
@DuYicong515 DuYicong515 force-pushed the deprecation/parallel_device_ids branch 2 times, most recently from 9ceef90 to 71adddb Compare February 25, 2022 19:15
@ananthsub ananthsub added the deprecation Includes a deprecation label Feb 25, 2022
@DuYicong515 DuYicong515 requested a review from carmocca February 25, 2022 20:20
awaelchli
awaelchli suggested changes Feb 26, 2022
View reviewed changes
tests/models/test_gpu.py Outdated Show resolved Hide resolved
tests/models/test_gpu.py Outdated Show resolved Hide resolved
tests/callbacks/test_gpu_stats_monitor.py Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Mar 21, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Mar 21, 2022
@mergify mergify bot removed the has conflicts label Mar 21, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) March 22, 2022 09:58
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Mar 22, 2022
auto-merge was automatically disabled March 22, 2022 16:27

Head branch was pushed to by a user without write access

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 22, 2022
rohitgr7
rohitgr7 approved these changes Mar 23, 2022
View reviewed changes
tests/trainer/test_trainer_cli.py Show resolved Hide resolved
@daniellepintz daniellepintz added this to the 1.6 milestone Mar 23, 2022
@ananthsub ananthsub enabled auto-merge (squash) March 23, 2022 21:41
@ananthsub ananthsub merged commit 9231741 into Lightning-AI:master Mar 23, 2022
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
12 tasks
@Borda Borda changed the title Remove Accelerator.parallel_device_ids and deprecate Trainer.data_parallel_device_ids Remove Accelerator.parallel_device_ids and deprecate Trainer.data_parallel_device_ids Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@four4fish four4fish four4fish approved these changes

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
deprecation Includes a deprecation ready PRs ready to be merged trainer
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

RemoveAcceleratorConnector.parallel_device_ids and deprecate Trainer.data_parallel_device_ids
9 participants
@DuYicong515 @ananthsub @awaelchli @carmocca @tchaton @rohitgr7 @kaushikb11 @four4fish @daniellepintz