Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepspeed scheduler initialization #12031

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Fix deepspeed scheduler initialization #12031

merged 2 commits into from
Mar 21, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Feb 21, 2022

What does this PR do?

Fixes #11694

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren @awaelchli @rohitgr7

@rohitgr7 rohitgr7 added bug Something isn't working strategy: deepspeed labels Feb 21, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Feb 21, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still draft? LGTM!

@rohitgr7
Copy link
Contributor Author

Still draft? LGTM!

waiting for the user's confirmation this time over the issue... hahah... forgot to test it last time so making sure it's working now.

@rohitgr7 rohitgr7 marked this pull request as ready for review March 16, 2022 12:35
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitgr7 is on fire!

@mergify mergify bot added the ready PRs ready to be merged label Mar 19, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) March 21, 2022 10:17
@rohitgr7 rohitgr7 merged commit 865c54f into master Mar 21, 2022
@rohitgr7 rohitgr7 deleted the fix/deepspeed_step_lr branch March 21, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged strategy: deepspeed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepSpeed learning rate scheduler not working
4 participants