Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pluggable Accelerators #12030

Merged
merged 42 commits into from
Feb 28, 2022
Merged

Add support for pluggable Accelerators #12030

merged 42 commits into from
Feb 28, 2022

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Feb 21, 2022 •
edited
Loading

What does this PR do?

Supports #10687

trainer = Trainer(accelerator=NewSOTAAccelerator(), devices=4)

Also, fixes #12044 and #10592

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @akihironitta @rohitgr7 @justusschock

@kaushikb11 kaushikb11 self-assigned this Feb 21, 2022
@kaushikb11 kaushikb11 added accelerator feature Is an improvement or enhancement labels Feb 21, 2022
@kaushikb11 kaushikb11 added this to the 1.6 milestone Feb 21, 2022
@kaushikb11 kaushikb11 marked this pull request as ready for review February 21, 2022 13:32
@mergify mergify bot removed the has conflicts label Feb 22, 2022
@kaushikb11 kaushikb11 mentioned this pull request Feb 22, 2022
Closed
@kaushikb11 kaushikb11 enabled auto-merge (squash) February 25, 2022 13:54
@mergify mergify bot added the ready PRs ready to be merged label Feb 25, 2022
@mergify mergify bot removed the has conflicts label Feb 28, 2022
@kaushikb11 kaushikb11 merged commit a52a6ea into master Feb 28, 2022
@kaushikb11 kaushikb11 deleted the feat/pluggable_accelerators branch February 28, 2022 16:06
@kaushikb11 kaushikb11 mentioned this pull request Mar 1, 2022
Merged
12 tasks
@ananthsub ananthsub mentioned this pull request Mar 1, 2022
Closed
@kaushikb11 kaushikb11 mentioned this pull request Mar 2, 2022
Merged
12 tasks
facebook-github-bot pushed a commit to facebookresearch/ReAgent that referenced this pull request Mar 4, 2022
@tangbinh @facebook-github-bot
Add support for pluggable Accelerators (#12030)
7d5f5f7 
Summary:
### New commit log messages
- [a52a6ea03 Add support for pluggable Accelerators (#12030)](Lightning-AI/pytorch-lightning#12030)

Reviewed By: edward-io

Differential Revision: D34608197

fbshipit-source-id: ee87d0ce693659a4e689290a079f8c5a4772faf2
@kaushikb11 kaushikb11 mentioned this pull request Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@kaushikb11 kaushikb11

Labels
accelerator feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Import error when trying to run TPU accelerator on CPU
6 participants
@kaushikb11 @awaelchli @Borda @carmocca @justusschock @rohitgr7