Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PrecisionPlugin.on_save/load_checkpoint #11978

Merged
merged 21 commits into from
Mar 2, 2022

Conversation

jjenniferdai
Copy link
Contributor

@jjenniferdai jjenniferdai commented Feb 18, 2022

What does this PR do?

Part of #11824
Deprecate PrecisionPlugin.on_save/load_checkpoint hooks

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@jjenniferdai jjenniferdai marked this pull request as ready for review February 18, 2022 06:46
@ananthsub ananthsub added this to the 1.6 milestone Feb 18, 2022
@ananthsub ananthsub added checkpointing Related to checkpointing deprecation Includes a deprecation precision: apex (removed) NVIDIA/apex precision precision: amp Automatic Mixed Precision labels Feb 18, 2022
pytorch_lightning/plugins/precision/apex_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/native_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/apex_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/apex_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/native_amp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/precision/native_amp.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Feb 25, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Feb 28, 2022
@ananthsub ananthsub merged commit d923dff into Lightning-AI:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing deprecation Includes a deprecation precision: amp Automatic Mixed Precision precision: apex (removed) NVIDIA/apex precision ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants