-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PrecisionPlugin.on_save/load_checkpoint
#11978
Merged
ananthsub
merged 21 commits into
Lightning-AI:master
from
jjenniferdai:depr-precplugin-cphooks
Mar 2, 2022
Merged
Deprecate PrecisionPlugin.on_save/load_checkpoint
#11978
ananthsub
merged 21 commits into
Lightning-AI:master
from
jjenniferdai:depr-precplugin-cphooks
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
jjenniferdai
requested review from
williamFalcon,
Borda,
tchaton,
SeanNaren,
carmocca,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
February 18, 2022 06:46
ananthsub
added
checkpointing
Related to checkpointing
deprecation
Includes a deprecation
precision: apex (removed)
NVIDIA/apex precision
precision: amp
Automatic Mixed Precision
labels
Feb 18, 2022
ananthsub
approved these changes
Feb 18, 2022
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
for more information, see https://pre-commit.ci
ananthsub
approved these changes
Feb 18, 2022
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
for more information, see https://pre-commit.ci
ananthsub
reviewed
Feb 18, 2022
12 tasks
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
awaelchli
approved these changes
Feb 26, 2022
awaelchli
reviewed
Feb 26, 2022
awaelchli
reviewed
Feb 26, 2022
for more information, see https://pre-commit.ci
Co-authored-by: Adrian Wälchli <[email protected]>
rohitgr7
approved these changes
Feb 28, 2022
carmocca
approved these changes
Feb 28, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
checkpointing
Related to checkpointing
deprecation
Includes a deprecation
precision: amp
Automatic Mixed Precision
precision: apex (removed)
NVIDIA/apex precision
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #11824
Deprecate
PrecisionPlugin.on_save/load_checkpoint
hooksDoes your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃