-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DDPSpawnStrategy.get_mp_spawn_kwargs
in favor of launchers
#11966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
tchaton,
SeanNaren,
justusschock,
kaushikb11,
williamFalcon,
Borda,
carmocca and
rohitgr7
as code owners
February 17, 2022 21:52
awaelchli
commented
Feb 17, 2022
ananthsub
approved these changes
Feb 17, 2022
carmocca
approved these changes
Feb 17, 2022
11 tasks
rohitgr7
approved these changes
Feb 22, 2022
kaushikb11
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just start_method
needs to be removed from _XLASpawnLauncher
's constructor.
Also, loving the Launcher Strategy interface.
kaushikb11
reviewed
Feb 22, 2022
awaelchli
added
strategy: ddp
DistributedDataParallel
and removed
strategy: ddp spawn
labels
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
ready
PRs ready to be merged
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10895
Follow up to #11643
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7