Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DDPSpawnStrategy.get_mp_spawn_kwargs in favor of launchers #11966

Merged
merged 6 commits into from
Feb 22, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 17, 2022

What does this PR do?

Fixes #10895
Follow up to #11643

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7

@awaelchli awaelchli added breaking change Includes a breaking change strategy: ddp spawn labels Feb 17, 2022
@awaelchli awaelchli added this to the 1.6 milestone Feb 17, 2022
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just start_method needs to be removed from _XLASpawnLauncher's constructor.

Also, loving the Launcher Strategy interface.

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Feb 22, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 22, 2022 10:50
@awaelchli awaelchli merged commit de1815f into master Feb 22, 2022
@awaelchli awaelchli deleted the refactor/mp-spawn-kwargs branch February 22, 2022 11:28
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate or re-purpose the get_mp_spawn_kwargs hook in spawn plugins
5 participants