-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the behavior with limit_*_batches=1|1.0
#11950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Feb 16, 2022
thank you!!!!! |
carmocca
requested review from
williamFalcon,
tchaton,
awaelchli,
justusschock,
Borda,
SeanNaren,
kaushikb11 and
rohitgr7
as code owners
February 17, 2022 00:28
rohitgr7
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
ananthsub
reviewed
Feb 17, 2022
ananthsub
reviewed
Feb 17, 2022
ananthsub
approved these changes
Feb 17, 2022
12 tasks
awaelchli
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The behavior for
limit_*_batches
is wildly different when the user passes1
vs1.0
. This can be a footgun.This PR aims to increase transparency by showing a message clarifying the behavior.
In reaction to https://twitter.com/jxmnop/status/1494007900494303243 cc @Borda @jxmorris12
Proposed by @williamFalcon
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review