Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing _ddp_params_and_buffers_to_ignore #11949

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fix passing _ddp_params_and_buffers_to_ignore #11949

merged 1 commit into from
Feb 24, 2022

Conversation

Honzys
Copy link
Contributor

@Honzys Honzys commented Feb 16, 2022 •
edited
Loading

What does this PR do?

When wrapping the LightningModule with some wrapper
classes, names of the params and buffers to ignore
should be prefixed with the name of the variable to which
is the LightningModule assigned.

Fixes #11844

Does your PR introduce any breaking changes? If yes, please list them.

I hope not.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Honzys Honzys force-pushed the fix_ddp_params_and_buffers_to_ignore branch from b366f2c to 00ab80b Compare February 16, 2022 21:16
@Honzys Honzys marked this pull request as ready for review February 16, 2022 23:47
@Honzys
Copy link
Contributor Author

Honzys commented Feb 16, 2022

I guess I should update the CHANGELOG -> should I add the comment under the version 1.6.0 or somewhere else?
Also should I change the target branch to release/1.5.x as the milestone added to the issue is 1.5.x?

@awaelchli
Copy link
Contributor

awaelchli commented Feb 19, 2022 •
edited
Loading

@Honzys nice

You can add the changelog under the 1.6.0 "Fixed" section. Your branch should target master, no further action required :)

@awaelchli awaelchli added bug Something isn't working strategy: ddp DistributedDataParallel labels Feb 19, 2022
awaelchli
awaelchli approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid fix!

@awaelchli awaelchli added this to the 1.6 milestone Feb 19, 2022
akihironitta
akihironitta approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Once the changelog gets updated, LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Feb 20, 2022
@Honzys Honzys force-pushed the fix_ddp_params_and_buffers_to_ignore branch from 00ab80b to 6044a02 Compare February 20, 2022 21:28
@Honzys
Copy link
Contributor Author

Honzys commented Feb 20, 2022

I've just updated the CHANGELOG, so it should be ready from my part.

@Honzys
Fix passing _ddp_params_and_buffers_to_ignore
e1bef09 
When wrapping the LightningModule with some wrapper
classes, names of the params and buffers to ignore
should be prefixed with the name of the variable to which
is the LightningModule assigned.
@Honzys Honzys force-pushed the fix_ddp_params_and_buffers_to_ignore branch from 6044a02 to e1bef09 Compare February 23, 2022 12:05
@mergify mergify bot removed the has conflicts label Feb 23, 2022
@kaushikb11 kaushikb11 enabled auto-merge (squash) February 23, 2022 12:50
@carmocca carmocca modified the milestones: 1.6, 1.5.x Feb 24, 2022
tchaton
tchaton approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kaushikb11 kaushikb11 merged commit c877d54 into Lightning-AI:master Feb 24, 2022
facebook-github-bot pushed a commit to facebookresearch/recipes that referenced this pull request Mar 4, 2022
@tangbinh @facebook-github-bot
Fix passing _ddp_params_and_buffers_to_ignore (#11949)
8b0f2ca 
Summary:
### New commit log messages
- [c877d54c0 Fix passing _ddp_params_and_buffers_to_ignore (#11949)](Lightning-AI/pytorch-lightning#11949)

Reviewed By: daniellepintz

Differential Revision: D34576812

fbshipit-source-id: 33f3677329d333acd049f673da67d6d9a509d152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

_LightningModuleWrapperBase doesn't pass attribute _ddp_params_and_buffers_to_ignore correctly
7 participants
@Honzys @awaelchli @carmocca @tchaton @akihironitta @rohitgr7 @kaushikb11