Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback to manage fault-tolerance checkpoints #11862

Merged
merged 7 commits into from
Feb 22, 2022
Merged

Add callback to manage fault-tolerance checkpoints #11862

merged 7 commits into from
Feb 22, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 10, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Part of #9130

This callback is not meant to be used publicly.
There are tests that cover this works.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @rohitgr7 @ananthsub @daniellepintz @carmocca @ninginthecloud @akihironitta

@carmocca carmocca added this to the 1.6 milestone Feb 10, 2022
@carmocca carmocca self-assigned this Feb 10, 2022
@carmocca carmocca changed the title Add callback to save fault-tolerance checkpoints Add callback to manage fault-tolerance checkpoints Feb 10, 2022
@carmocca carmocca force-pushed the feat/ft-ckpt-callback branch from 1a67dbc to c28834b Compare February 11, 2022 00:34
@carmocca carmocca marked this pull request as ready for review February 11, 2022 01:05
@daniellepintz
Copy link
Contributor

Hi @carmocca, any thoughts on #11768 (comment)?

@carmocca carmocca mentioned this pull request Feb 12, 2022
Closed
daniellepintz
daniellepintz reviewed Feb 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@carmocca @daniellepintz
Update CHANGELOG.md
2ef811b 
Co-authored-by: Danielle Pintz <[email protected]>
@carmocca carmocca mentioned this pull request Feb 14, 2022
Closed
@daniellepintz
Copy link
Contributor

@carmocca is this PR ready to go or is it waiting on something? I ask because I'd like to start working on #11768

@carmocca
Copy link
Contributor Author

It's waiting on 3 approvals + CI working

@carmocca carmocca enabled auto-merge (squash) February 21, 2022 14:25
@mergify mergify bot added the ready PRs ready to be merged label Feb 22, 2022
tchaton
tchaton approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/callbacks/fault_tolerance.py Show resolved Hide resolved
@carmocca carmocca merged commit 2d04385 into master Feb 22, 2022
@carmocca carmocca deleted the feat/ft-ckpt-callback branch February 22, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellepintz daniellepintz daniellepintz left review comments

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees

@carmocca carmocca

Labels
callback fault tolerance ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@carmocca @daniellepintz @ananthsub @awaelchli @tchaton