Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save_hyperparameters when no parameters need saving #11827

Merged
merged 6 commits into from
Feb 9, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 9, 2022

What does this PR do?

Fixes #11825

The newly added test cases both fail on master.

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @justusschock @awaelchli @Borda @ananthsub @ninginthecloud @jjenniferdai @rohitgr7

@awaelchli awaelchli added bug Something isn't working lightningmodule pl.LightningModule labels Feb 9, 2022
@awaelchli awaelchli added this to the 1.5.x milestone Feb 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 9, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) February 9, 2022 20:14
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #11827 (dbc3e8a) into master (1e36cff) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #11827    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         198      198            
  Lines       17321    17319     -2     
========================================
- Hits        15852    15180   -672     
- Misses       1469     2139   +670     

@tchaton tchaton merged commit c618e59 into master Feb 9, 2022
@tchaton tchaton deleted the bugfix/ignore-params branch February 9, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningmodule pl.LightningModule ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving hyperparameters fails if all parameters in the signature get ignored
4 participants