-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to avoid moving batch to device for DataParallel #11780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just a side-note: without transfering to gpu0 first in a non-blocking way, this may actually be a bit slower, since depending on how gpus are connected, data transfer between gpus can be then transfer between cpu and gpu :)
However, I still think we should merge this fix, since otherwise users are restricted in their batchsize since actually the batches of both gpus need to fit to one gpu first :)
Co-authored-by: ananthsub <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: ananthsub <[email protected]>
What does this PR do?
Discussed here: #10649 (comment)
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7