Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to avoid moving batch to device for DataParallel #11780

Merged
merged 5 commits into from
Feb 7, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Feb 7, 2022

What does this PR do?

Discussed here: #10649 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7

@rohitgr7 rohitgr7 added bug Something isn't working strategy: dp (removed in pl) DataParallel labels Feb 7, 2022
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Feb 7, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review February 7, 2022 10:26
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 7, 2022
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a side-note: without transfering to gpu0 first in a non-blocking way, this may actually be a bit slower, since depending on how gpus are connected, data transfer between gpus can be then transfer between cpu and gpu :)

However, I still think we should merge this fix, since otherwise users are restricted in their batchsize since actually the batches of both gpus need to fit to one gpu first :)

Co-authored-by: ananthsub <[email protected]>
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 7, 2022 10:41
@mergify mergify bot added the has conflicts label Feb 7, 2022
@mergify mergify bot removed the has conflicts label Feb 7, 2022
@rohitgr7 rohitgr7 merged commit 9ed44de into master Feb 7, 2022
@rohitgr7 rohitgr7 deleted the fix/dp_batch_transfer branch February 7, 2022 14:26
rohitgr7 added a commit that referenced this pull request Feb 7, 2022
rohitgr7 added a commit that referenced this pull request Feb 7, 2022
rohitgr7 added a commit that referenced this pull request Feb 8, 2022
rohitgr7 added a commit that referenced this pull request Feb 8, 2022
lexierule pushed a commit that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged strategy: dp (removed in pl) DataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants