Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Horovod teardown() to complete gracefully if exception thrown in callback setup #11752

Merged
merged 3 commits into from
Feb 5, 2022

Conversation

speediedan
Copy link
Contributor

@speediedan speediedan commented Feb 5, 2022

What does this PR do?

Fixes: #11751

HorovodStrategy.teardown() may not complete gracefully if an exception is thrown before HorovodStrategy._exit_stack is set. Providing a simple fix that verifies _exit_stack is set before attempting to use it.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • [] Is this pull request ready for review? (if not, please submit in draft mode)
  • [] Check that all items from Before submitting are resolved
  • [] Make sure the title is self-explanatory and the description concisely explains the PR
  • [] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@speediedan speediedan changed the title allow Horovod teardown() to complete gracefully if exception thrown… Allow Horovod teardown() to complete gracefully if exception thrown in callback setup Feb 5, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli added bug Something isn't working strategy: horovod (removed) labels Feb 5, 2022
@awaelchli awaelchli added this to the 1.5.x milestone Feb 5, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 5, 2022
@ananthsub ananthsub merged commit 9d8faec into Lightning-AI:master Feb 5, 2022
@rohitgr7 rohitgr7 modified the milestones: 1.5.x, 1.6 Feb 8, 2022
@speediedan speediedan deleted the bugfix/horovod_teardown branch May 12, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged strategy: horovod (removed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix HorovodStrategy Teardown() Edge Case
6 participants