-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying process group backend to relevant distributed strategies #11745
Merged
ananthsub
merged 19 commits into
Lightning-AI:master
from
ananthsub:feat/support-fairring
Mar 18, 2022
Merged
Add support for specifying process group backend to relevant distributed strategies #11745
ananthsub
merged 19 commits into
Lightning-AI:master
from
ananthsub:feat/support-fairring
Mar 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
force-pushed
the
feat/support-fairring
branch
2 times, most recently
from
February 7, 2022 08:36
6774abe
to
bfe8418
Compare
ananthsub
added
strategy: ddp
DistributedDataParallel
strategy: ddp spawn
strategy: deepspeed
strategy: fairscale fsdp (removed)
Fully Sharded Data Parallel
strategy: fairscale sharded (removed)
Sharded Data Parallel
distributed
Generic distributed-related topic
deprecation
Includes a deprecation
labels
Feb 7, 2022
ananthsub
force-pushed
the
feat/support-fairring
branch
from
February 7, 2022 17:58
0b645e3
to
85f257a
Compare
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
February 7, 2022 20:42
carmocca
reviewed
Feb 7, 2022
ananthsub
force-pushed
the
feat/support-fairring
branch
from
February 10, 2022 23:52
85f257a
to
6ab83d5
Compare
awaelchli
reviewed
Feb 14, 2022
ananthsub
force-pushed
the
feat/support-fairring
branch
from
February 16, 2022 08:38
6ab83d5
to
d4cd566
Compare
Codecov Report
@@ Coverage Diff @@
## master #11745 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 206 198 -8
Lines 17585 17387 -198
========================================
- Hits 16127 15233 -894
- Misses 1458 2154 +696 |
awaelchli
approved these changes
Mar 10, 2022
four4fish
approved these changes
Mar 10, 2022
Borda
approved these changes
Mar 14, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
ananthsub
force-pushed
the
feat/support-fairring
branch
from
March 18, 2022 05:45
1a81f5b
to
39b7cb0
Compare
12 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecation
Includes a deprecation
distributed
Generic distributed-related topic
ready
PRs ready to be merged
strategy: ddp
DistributedDataParallel
strategy: deepspeed
strategy: fairscale fsdp (removed)
Fully Sharded Data Parallel
strategy: fairscale sharded (removed)
Sharded Data Parallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11725
What does this PR do?
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃