Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WandbLogger's log_image can use step argument #11716

Merged
merged 9 commits into from
Feb 5, 2022
Merged

WandbLogger's log_image can use step argument #11716

merged 9 commits into from
Feb 5, 2022

Conversation

NathanGodey
Copy link
Contributor

What does this PR do?

Makes WandbLogger's log_image compatible with the step argument.

Fixes #11703

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

rohitgr7
rohitgr7 approved these changes Feb 3, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 added bug Something isn't working logger: wandb Weights & Biases labels Feb 3, 2022
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Feb 3, 2022
@mergify mergify bot added the has conflicts label Feb 3, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 3, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 5, 2022 00:34
@awaelchli
Copy link
Contributor

Thanks for contributing this fix! <3

@awaelchli awaelchli merged commit 8a1b1ee into Lightning-AI:master Feb 5, 2022
rohitgr7 added a commit that referenced this pull request Feb 7, 2022
@NathanGodey @pre-commit-ci
@rohitgr7 @carmocca
WandbLogger's log_image can use step argument (#11716)
2ce9d68 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
rohitgr7 added a commit that referenced this pull request Feb 8, 2022
@NathanGodey @pre-commit-ci
@rohitgr7 @carmocca
WandbLogger's log_image can use step argument (#11716)
b950c63 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
rohitgr7 added a commit that referenced this pull request Feb 8, 2022
@NathanGodey @pre-commit-ci
@rohitgr7 @carmocca
WandbLogger's log_image can use step argument (#11716)
f1f734e 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Feb 9, 2022
@NathanGodey @pre-commit-ci
@rohitgr7 @carmocca @lexierule
WandbLogger's log_image can use step argument (#11716)
88830aa 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working logger: wandb Weights & Biases ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

Using the step argument raises an error for WandbLogger's log_image
4 participants
@NathanGodey @awaelchli @carmocca @rohitgr7