Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rich progress bar metric render on epoch end #11689

Merged
merged 12 commits into from
Feb 3, 2022
Merged

Fix rich progress bar metric render on epoch end #11689

merged 12 commits into from
Feb 3, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Feb 1, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #10653 (for rich)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren @kaushikb11

@rohitgr7 rohitgr7 added bug Something isn't working progress bar: rich labels Feb 1, 2022
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Feb 1, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review February 1, 2022 13:35
carmocca
carmocca approved these changes Feb 1, 2022
View reviewed changes
pytorch_lightning/callbacks/progress/rich_progress.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/progress/rich_progress.py Outdated Show resolved Hide resolved
tests/callbacks/progress/test_common_progress.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from carmocca February 1, 2022 15:02
@mergify mergify bot added the ready PRs ready to be merged label Feb 2, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 2, 2022 20:10
@mergify mergify bot added the has conflicts label Feb 2, 2022
@mergify mergify bot removed the has conflicts label Feb 2, 2022
@rohitgr7 rohitgr7 merged commit ee049e1 into master Feb 3, 2022
@rohitgr7 rohitgr7 deleted the fix/rich_epoch_end2 branch February 3, 2022 01:43
rohitgr7 added a commit that referenced this pull request Feb 7, 2022
@rohitgr7 @carmocca @Borda
Fix rich progress bar metric render on epoch end (#11689)
0f98ad4 
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Jirka <[email protected]>
lexierule pushed a commit that referenced this pull request Feb 9, 2022
@rohitgr7 @carmocca
@Borda @lexierule
Fix rich progress bar metric render on epoch end (#11689)
5f616ac 
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Jirka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
bug Something isn't working progress bar: rich ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

Progressbar showed different value vs tensorboard and myself output
4 participants
@rohitgr7 @Borda @carmocca @kaushikb11