-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create loggers property for Trainer and LightningModule #11683
Create loggers property for Trainer and LightningModule #11683
Conversation
for more information, see https://pre-commit.ci
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
edbdbb7
to
1ad542a
Compare
95e173b
to
9d564d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
for more information, see https://pre-commit.ci
We are going to handle the special case for the loggers setter where someone assigns If we try to manually check and sanitize this everywhere it occurs in the codebase, it will be harder to deprecate LoggerCollection and trainer.logger. Sanitizing the input to trainer.loggers would also remove information about whether the user provided a LoggerCollection, which would lead to incorrect behavior if the LoggerCollection is of size 1. There are multiple solutions to this problem but, in my opinion, they are all messier than adding a special case to the setter. |
Could someone please rerun the CI and enable auto-merge? |
Can we update this PR to include the proposal in #11232 (comment)? |
Co-authored-by: ananthsub <[email protected]>
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your persistence on this. I think it's ready to merge
What does this PR do?
Implement a loggers property that returns a list of loggers. This is meant to replace LoggerCollection, which will then be deprecated.
Part of #11232
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃