Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop default argparse #1167

Merged
merged 5 commits into from
Mar 17, 2020
Merged

drop default argparse #1167

merged 5 commits into from
Mar 17, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Mar 17, 2020

coverage increase

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1167 into master will not change coverage.
The diff coverage is 92%.

@@          Coverage Diff           @@
##           master   #1167   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          63      63           
  Lines        3210    3210           
======================================
  Hits         2811    2811           
  Misses        399     399

@williamFalcon williamFalcon merged commit c32e3f3 into master Mar 17, 2020
@Borda Borda deleted the cov branch March 17, 2020 07:38
@Borda Borda added the ci Continuous Integration label Mar 17, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 17, 2020
Borda added a commit that referenced this pull request Mar 17, 2020
* fixed docs

* Docs (#1164)

* fixed docs

* fixed docs

* fixed docs

* fixing Win failed import (#1163)

* version

* try fix distrib

* update try import

* fixed docs

Co-authored-by: Jirka Borovec <[email protected]>
@Borda Borda mentioned this pull request Mar 17, 2020
@Borda Borda changed the title coverage increase drop default argparse Mar 17, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
* fixed docs

* Docs (Lightning-AI#1164)

* fixed docs

* fixed docs

* fixed docs

* fixing Win failed import (Lightning-AI#1163)

* version

* try fix distrib

* update try import

* fixed docs

Co-authored-by: Jirka Borovec <[email protected]>
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants