Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rich with uneven refresh rate tracking #11668

Merged
merged 14 commits into from
Feb 3, 2022
Merged

Fix rich with uneven refresh rate tracking #11668

merged 14 commits into from
Feb 3, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 31, 2022

What does this PR do?

2 fixes here:

  • One when refresh_rate isn't aligned with progress total, for eg. if total is 11 and refresh_rate is 5, it doesn't end up with the correct total.
  • When using val_check_interval, rich validation bar shows total as the total number of validation steps going to happen during a single epoch, rather it should only show the total for one validation loop just like tqdm

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren @kaushikb11

@rohitgr7 rohitgr7 added bug Something isn't working progress bar: rich labels Jan 31, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need this in a bug-fix release?

pytorch_lightning/callbacks/progress/rich_progress.py Outdated Show resolved Hide resolved
tests/callbacks/test_rich_progress_bar.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jan 31, 2022
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Jan 31, 2022
@rohitgr7
Copy link
Contributor Author

Looks good. Do we need this in a bug-fix release?

yes, if we are going to make one.

Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohitgr7!

@rohitgr7 rohitgr7 enabled auto-merge (squash) January 31, 2022 15:52
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Feb 2, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 merged commit e9065e9 into master Feb 3, 2022
@rohitgr7 rohitgr7 deleted the fix/rich_refresh branch February 3, 2022 10:27
@rohitgr7 rohitgr7 modified the milestones: 1.5.x, 1.6 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working progress bar: rich ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants