Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TQDM progress bar tracking with multiple dataloaders #11657

Merged
merged 25 commits into from
Mar 25, 2022
Merged

Update TQDM progress bar tracking with multiple dataloaders #11657

merged 25 commits into from
Mar 25, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 28, 2022 •
edited
Loading

What does this PR do?

Fixes #11615
More specifically, the PR now enables that a new bar is being used for each eval dataloaders. It won't destroy the old one after the first dataloader is completer, rather it resets it.

This is how it will look like: #11615 (comment)

Screen.Recording.2022-02-10.at.1.47.51.AM.mov

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @rohitgr7

@rohitgr7 rohitgr7 added this to the 1.5.x milestone Jan 28, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review January 31, 2022 10:37
@carmocca
Copy link
Contributor

Does this implement the separate progress bar idea described in the linked issue?

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Jan 31, 2022 •
edited
Loading

Does this implement the separate progress bar idea described in the linked issue?

no, I have mentioned the reason on the issue why I didn't go in that direction for now. For now, it just fixes the bug. To support the idea for a different progress bar, I need some more time to look at whether it will be possible with the rich progress bar as well. Will keep that open to discuss possible solutions.

@carmocca
Copy link
Contributor

Just synced with Rohit, we are going to try to pursue the separate bar idea first and if that does not work out, continue this PR. That feature replaces this fix because this is not a problem in the bug-fix branch.

carmocca
carmocca reviewed Jan 31, 2022
View reviewed changes
pytorch_lightning/callbacks/progress/base.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/progress/base.py Show resolved Hide resolved
pytorch_lightning/callbacks/progress/base.py Show resolved Hide resolved
pytorch_lightning/loops/dataloader/evaluation_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/progress/rich_progress.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/progress/tqdm_progress.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/progress/tqdm_progress.py Show resolved Hide resolved
pytorch_lightning/callbacks/progress/tqdm_progress.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/progress/base.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/progress/tqdm_progress.py Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from carmocca February 1, 2022 10:21
@rohitgr7 rohitgr7 mentioned this pull request Feb 2, 2022
Merged
12 tasks
@rohitgr7 rohitgr7 requested a review from carmocca February 24, 2022 17:34
@mergify mergify bot added the ready PRs ready to be merged label Feb 25, 2022
@mergify mergify bot removed the has conflicts label Feb 28, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 28, 2022 13:02
@rohitgr7 rohitgr7 requested a review from Borda February 28, 2022 13:12
kaushikb11
kaushikb11 reviewed Mar 7, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Borda Borda requested a review from kaushikb11 March 14, 2022 09:41
@rohitgr7 rohitgr7 added the breaking change Includes a breaking change label Mar 16, 2022
@rohitgr7 rohitgr7 requested a review from kaushikb11 March 23, 2022 14:50
@rohitgr7 rohitgr7 requested a review from Borda March 24, 2022 14:00
@rohitgr7 rohitgr7 merged commit e631a66 into master Mar 25, 2022
@rohitgr7 rohitgr7 deleted the ref/eval_progress branch March 25, 2022 15:13
@awaelchli awaelchli mentioned this pull request Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@rohitgr7 rohitgr7

Labels
breaking change Includes a breaking change bug Something isn't working feature Is an improvement or enhancement progress bar: tqdm ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

tqdm progress not working correctly with multiple dataloaders
5 participants
@rohitgr7 @carmocca @awaelchli @Borda @kaushikb11