Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Stateful PrecisionPlugin #11638

Merged
merged 20 commits into from
Feb 14, 2022
Merged

Introduce Stateful PrecisionPlugin #11638

merged 20 commits into from
Feb 14, 2022
+80 −16

Conversation

jjenniferdai
Copy link
Contributor

@jjenniferdai jjenniferdai commented Jan 27, 2022 •
edited
Loading

What does this PR do?

part of / Fixes #11429: introduce Stateful PrecisionPlugin (see Appendix code changes outlined in issue)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@jjenniferdai jjenniferdai marked this pull request as ready for review January 28, 2022 01:08
ananthsub
ananthsub reviewed Jan 28, 2022
View reviewed changes
Copy link
Contributor

@ananthsub ananthsub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a follow up, please deprecate CheckpointHooks off the PrecisionPlugin interface: https://github.com/PyTorchLightning/pytorch-lightning/blob/86b177ebe5427725b35fde1a8808a7b59b8a277a/pytorch_lightning/plugins/precision/precision_plugin.py#L29

It is no longer needed following the Stateful change and should be removed in v1.8

pytorch_lightning/trainer/connectors/checkpoint_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/checkpoint_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/checkpoint_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/checkpoint_connector.py Outdated Show resolved Hide resolved
@ananthsub ananthsub added this to the 1.6 milestone Jan 28, 2022
@ananthsub ananthsub added the checkpointing Related to checkpointing label Jan 28, 2022
Borda
Borda approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmocca let's merge this as it is and create an issue bout unifying the stateful mixin?

pytorch_lightning/plugins/precision/precision_plugin.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 5, 2022
@carmocca
Copy link
Contributor

carmocca commented Feb 7, 2022

let's merge this as it is and create an issue bout unifying the stateful mixin?

We can wait for @jjenniferdai to address comments.

@mergify mergify bot added the has conflicts label Feb 9, 2022
@mergify mergify bot removed the has conflicts label Feb 9, 2022
@awaelchli awaelchli mentioned this pull request Feb 9, 2022
Closed
@awaelchli awaelchli mentioned this pull request Feb 11, 2022
Closed
awaelchli
awaelchli approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we never had any tests around amp checkpointing (I couldn't find any?). I created this issue #11885 because we need some form of checks to be confident with refactors like these.

Borda
Borda approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohitgr7 rohitgr7 merged commit d69b33f into Lightning-AI:master Feb 14, 2022
rohitgr7 added a commit that referenced this pull request Feb 17, 2022
@jjenniferdai @rohitgr7 @ananthsub
Introduce Stateful PrecisionPlugin (#11638)
105c4b3 
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: ananthsub <[email protected]>
@jjenniferdai jjenniferdai mentioned this pull request Feb 18, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton left review comments

@ananthsub ananthsub ananthsub approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
checkpointing Related to checkpointing ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Standardize all stateful components on state_dict/load_state_dict
8 participants
@jjenniferdai @carmocca @ananthsub @awaelchli @Borda @tchaton @justusschock @rohitgr7