Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experiment property from logger base class. #11603

Merged
merged 9 commits into from
Feb 3, 2022
Merged

Remove experiment property from logger base class. #11603

merged 9 commits into from
Feb 3, 2022

Conversation

akashkw
Copy link
Contributor

@akashkw akashkw commented Jan 24, 2022 •
edited
Loading

What does this PR do?

Remove experiment from abstract class. We will still leave experiment in our logger implementations, but we will no longer make that a requirement.

Fixes #11234

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akashkw akashkw marked this pull request as ready for review January 24, 2022 19:39
rohitgr7
rohitgr7 reviewed Jan 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
daniellepintz
daniellepintz reviewed Jan 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@akashkw akashkw changed the title Deprecate experiment property from abstract class. Remove experiment property from abstract class. Jan 24, 2022
daniellepintz
daniellepintz reviewed Jan 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ananthsub ananthsub added the logger Related to the Loggers label Jan 24, 2022
@awaelchli awaelchli added design Includes a design discussion refactor labels Jan 24, 2022
@awaelchli awaelchli added this to the 1.6 milestone Jan 24, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 24, 2022
@daniellepintz
Copy link
Contributor

@akashkw if you merge with master the test failures should go away

@daniellepintz
Copy link
Contributor

daniellepintz commented Feb 2, 2022 •
edited
Loading

Can someone with access enable auto-merge on this please?

@mergify mergify bot added the has conflicts label Feb 2, 2022
@carmocca carmocca enabled auto-merge (squash) February 2, 2022 21:37
@mergify mergify bot removed the has conflicts label Feb 2, 2022
@ananthsub ananthsub changed the title Remove experiment property from abstract class. Remove experiment property from logger base class. Feb 2, 2022
@daniellepintz
Copy link
Contributor

Looks like we need a rerun on the TPU tests :/ they seem to be quite flaky. Can someone with access help out?

@carmocca carmocca merged commit d5aa771 into Lightning-AI:master Feb 3, 2022
@akashkw akashkw deleted the refactor/deprecate-abstract-logger-experiment branch February 3, 2022 01:53
facebook-github-bot pushed a commit to facebookresearch/recipes that referenced this pull request Feb 4, 2022
@ninginthecloud @facebook-github-bot
Remove experiment property from abstract class (#11603)
39683ce 
Summary:
### New commit log messages
- [d5aa7717a Remove experiment property from abstract class (#11603)](Lightning-AI/pytorch-lightning#11603)

Reviewed By: daniellepintz, ananthsub

Differential Revision: D33985339

fbshipit-source-id: 67d069074d80ddda92bdbb6d770aa920341a0083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton left review comments

@daniellepintz daniellepintz daniellepintz approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edward-io edward-io Awaiting requested review from edward-io

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
design Includes a design discussion logger Related to the Loggers ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Deprecate LightningLoggerBase.experiment requirement from Logger interface
8 participants
@akashkw @daniellepintz @ananthsub @awaelchli @carmocca @tchaton @justusschock @rohitgr7