Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate on_epoch_start/on_epoch_end hook #11578

Merged
merged 14 commits into from
Feb 7, 2022
Merged

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 22, 2022

  • deprecate on_epoch_start and on_epoch_end
  • add test

What does this PR do?

Part of #10807

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @awaelchli @ananthsub @daniellepintz @rohitgr7 @tchaton @akihironitta @carmocca @justusschock @Borda @ninginthecloud @jjenniferdai

@rohitgr7 rohitgr7 added callback deprecation Includes a deprecation labels Jan 22, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Jan 22, 2022
@rohitgr7 rohitgr7 added the lightningmodule pl.LightningModule label Jan 22, 2022
@akihironitta akihironitta added the hooks Related to the hooks API label Jan 24, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/common/lightning_module.rst Show resolved Hide resolved
pytorch_lightning/callbacks/base.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jan 25, 2022
@mergify mergify bot added the has conflicts label Feb 2, 2022
@rohitgr7 rohitgr7 requested a review from Borda February 3, 2022 13:25
@mergify mergify bot removed the has conflicts label Feb 4, 2022
@mergify mergify bot added the has conflicts label Feb 7, 2022
@mergify mergify bot removed the has conflicts label Feb 7, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 7, 2022 13:19
@rohitgr7 rohitgr7 merged commit 581bf7f into master Feb 7, 2022
@rohitgr7 rohitgr7 deleted the dep/on_epoch_start_end branch February 7, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback deprecation Includes a deprecation hooks Related to the hooks API lightningmodule pl.LightningModule ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants