Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid loading dataloaders if limit_batches=0 #11576

Merged
merged 8 commits into from
Feb 22, 2022
Merged

Avoid loading dataloaders if limit_batches=0 #11576

merged 8 commits into from
Feb 22, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 22, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes: #11587

in short: if we say limit_val_batches=0 means no validation, why even load the dataloaders?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @ninginthecloud

@rohitgr7 rohitgr7 added bug Something isn't working data handling Generic data-related topic labels Jan 22, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Jan 22, 2022
@rohitgr7 rohitgr7 changed the title Avoid loading dataloaders if limit_batches=0 Avoid loading dataloaders if limit_batches=0 Jan 22, 2022
@amoudgl amoudgl mentioned this pull request Jan 22, 2022
Closed
@rohitgr7 rohitgr7 force-pushed the fix/dl_reload_limit_batches branch from 7a870a5 to 0e2d753 Compare February 1, 2022 11:10
@rohitgr7 rohitgr7 marked this pull request as ready for review February 8, 2022 20:01
carmocca
carmocca reviewed Feb 8, 2022
View reviewed changes
tests/models/test_hooks.py Show resolved Hide resolved
tests/models/test_hooks.py Show resolved Hide resolved
tests/trainer/test_dataloaders.py Show resolved Hide resolved
tchaton
tchaton approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat work !

@rohitgr7 rohitgr7 requested a review from carmocca February 9, 2022 20:03
@mergify mergify bot added the ready PRs ready to be merged label Feb 10, 2022
awaelchli
awaelchli reviewed Feb 14, 2022
View reviewed changes
tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
tests/trainer/test_dataloaders.py Show resolved Hide resolved
tests/trainer/test_dataloaders.py Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from awaelchli February 14, 2022 10:09
Borda
Borda approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot removed the has conflicts label Feb 21, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) February 21, 2022 09:24
@mergify mergify bot removed the has conflicts label Feb 21, 2022
@rohitgr7 rohitgr7 merged commit 5ea811b into master Feb 22, 2022
@rohitgr7 rohitgr7 deleted the fix/dl_reload_limit_batches branch February 22, 2022 11:33
adamreeve added a commit to adamreeve/pytorch-lightning that referenced this pull request Feb 27, 2022
@adamreeve
Fix for master change that broke resuming without validation dataloaders
c7c2818 
Changes in Lightning-AI#11576
caused a crash when restarting with limit_val_batches = 0
@adamreeve adamreeve mentioned this pull request Feb 27, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Inconsistency with loading dataloaders when limit_batches=0
5 participants
@rohitgr7 @awaelchli @Borda @carmocca @tchaton