Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid enforcing shuffle=False for eval dataloaders #11575

Merged
merged 5 commits into from
Feb 3, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 22, 2022

What does this PR do?

Fixes #11054

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @ninginthecloud

@rohitgr7 rohitgr7 added bug Something isn't working data handling Generic data-related topic labels Jan 22, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Jan 22, 2022
@rohitgr7 rohitgr7 requested a review from carmocca January 24, 2022 17:41
@mergify mergify bot added the ready PRs ready to be merged label Jan 25, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) January 27, 2022 07:48
@mergify mergify bot added the has conflicts label Feb 2, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
@tchaton tchaton merged commit 7948ed7 into master Feb 3, 2022
@tchaton tchaton deleted the fix/dist_eval_dl_shuffle branch February 3, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting shuffle=True for val_dataloader doesn't work when ddp enabled.
4 participants