Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in preparation to #8578 #11562

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Changes in preparation to #8578 #11562

merged 5 commits into from
Feb 2, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 21, 2022

What does this PR do?

This PR includes an assortment of changes which are not relevant by themselves but are supposed to make reviewing #8578 easier.

Part of #8578

Does your PR introduce any breaking changes? If yes, please list them.

Removes FitLoop.current_epoch. The property will have no purpose after #8578. Also having a setter there is dangerous.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @carmocca @ananthsub @ninginthecloud

@carmocca carmocca added refactor loops Related to the Loop API labels Jan 21, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 21, 2022
@carmocca carmocca self-assigned this Jan 21, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jan 23, 2022
@carmocca carmocca enabled auto-merge (squash) February 2, 2022 18:17
@carmocca carmocca merged commit a44881c into master Feb 2, 2022
@carmocca carmocca deleted the refactor/preparation-8578 branch February 2, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loops Related to the Loop API ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants