-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in preparation to #8578 #11562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
SkafteNicki,
tchaton and
williamFalcon
as code owners
January 21, 2022 03:21
tchaton
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
commented
Jan 23, 2022
carmocca
commented
Jan 23, 2022
rohitgr7
approved these changes
Jan 23, 2022
awaelchli
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes an assortment of changes which are not relevant by themselves but are supposed to make reviewing #8578 easier.
Part of #8578
Does your PR introduce any breaking changes? If yes, please list them.
Removes
FitLoop.current_epoch
. The property will have no purpose after #8578. Also having a setter there is dangerous.Before submitting
PR review
cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @carmocca @ananthsub @ninginthecloud