Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mid-epoch warning call while resuming #11556

Merged
merged 12 commits into from
Feb 3, 2022
Merged

Fix mid-epoch warning call while resuming #11556

merged 12 commits into from
Feb 3, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 20, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #11029

since we don't have the info regarding num training steps during checkpoint reload, we need to move it further once dataloaders are loaded.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@rohitgr7 rohitgr7 added the bug Something isn't working label Jan 20, 2022
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Jan 20, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review January 24, 2022 12:44
@rohitgr7 rohitgr7 requested a review from carmocca January 24, 2022 13:36
@rohitgr7 rohitgr7 requested a review from tchaton January 31, 2022 11:24
carmocca
carmocca approved these changes Jan 31, 2022
View reviewed changes
pytorch_lightning/loops/fit_loop.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 2, 2022
@mergify mergify bot added the has conflicts label Feb 2, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
@carmocca carmocca enabled auto-merge (squash) February 3, 2022 05:12
@carmocca carmocca merged commit 0cb64fb into master Feb 3, 2022
@carmocca carmocca deleted the fix/resume_warn branch February 3, 2022 05:42
@rohitgr7 rohitgr7 mentioned this pull request Feb 5, 2022
Merged
13 tasks
carmocca added a commit that referenced this pull request Feb 7, 2022
@carmocca
Revert #11556
834b8d7
carmocca added a commit that referenced this pull request Feb 7, 2022
@carmocca
Apply #11556
67c86d6
carmocca added a commit that referenced this pull request Feb 7, 2022
@carmocca
Apply #11556
9979454
rohitgr7 added a commit that referenced this pull request Feb 7, 2022
@rohitgr7 @carmocca @Borda
Fix mid-epoch warning call while resuming (#11556)
9801a54 
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Jirka <[email protected]>
carmocca added a commit that referenced this pull request Feb 7, 2022
@carmocca
Apply #11556
d8b7327
@rohitgr7 rohitgr7 mentioned this pull request Feb 8, 2022
Closed
carmocca added a commit that referenced this pull request Feb 10, 2022
@carmocca
Apply #11556
17ebb0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

Resuming training throws the mid-epoch warning everytime
5 participants
@rohitgr7 @Borda @carmocca @tchaton @kaushikb11