-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Support shorthand for loggers #11533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding a LOGGER_REGISTRY and then all good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Is there a way to set the defaults for a custom logger's arguments in code? e.g.
|
You can do it like: parser.set_defaults({
"trainer.logger": {
"class_path": "pytorch_lightning.loggers.TensorBoardLogger",
"init_args": {
"save_dir": "./logdir/"
}
}
}) |
What does this PR do?
Fixes #10574
Does your PR introduce any breaking changes? If yes, please list them.
Previous calls with
--trainer.logger=pytorch_lightning.loggers.WandbLogger
will need to update to--trainer.logger=WandbLogger
Before submitting
PR review
cc @Borda @awaelchli @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @carmocca @mauvilsa