Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Support shorthand for loggers #11533

Merged
merged 7 commits into from
Feb 3, 2022
Merged

[CLI] Support shorthand for loggers #11533

merged 7 commits into from
Feb 3, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 18, 2022

What does this PR do?

Fixes #10574

Does your PR introduce any breaking changes? If yes, please list them.

Previous calls with --trainer.logger=pytorch_lightning.loggers.WandbLogger will need to update to --trainer.logger=WandbLogger

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @awaelchli @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy @carmocca @mauvilsa

@carmocca carmocca added feature Is an improvement or enhancement logger Related to the Loggers breaking change Includes a breaking change lightningcli pl.cli.LightningCLI labels Jan 18, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 18, 2022
@carmocca carmocca self-assigned this Jan 18, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a LOGGER_REGISTRY and then all good :)

pytorch_lightning/utilities/cli.py Show resolved Hide resolved
pytorch_lightning/utilities/cli.py Outdated Show resolved Hide resolved
@carmocca carmocca requested a review from tchaton January 20, 2022 17:40
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jan 21, 2022
@carmocca carmocca enabled auto-merge (squash) January 21, 2022 13:48
@carmocca carmocca merged commit 3d3172d into master Feb 3, 2022
@carmocca carmocca deleted the cli/logger-shorthand branch February 3, 2022 02:58
@ia-davidpichler
Copy link

Is there a way to set the defaults for a custom logger's arguments in code? e.g.

class MyCLI(LightningCLI):
    def add_arguments_to_parser(self, parser) -> None:
        parser.set_defaults({
            "trainer.logger": "TensorBoardLogger",
            "trainer.logger.save_dir": "./logdir/"
        })

@mauvilsa
Copy link
Contributor

mauvilsa commented Mar 8, 2022

Is there a way to set the defaults for a custom logger's arguments in code?

You can do it like:

        parser.set_defaults({
            "trainer.logger": {
                "class_path": "pytorch_lightning.loggers.TensorBoardLogger",
                "init_args": {
                    "save_dir": "./logdir/"
                }
            }
        })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to pass logger to LightningCLI
6 participants