Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix available modules #11526

Merged
merged 6 commits into from
Feb 3, 2022
Merged

fix available modules #11526

merged 6 commits into from
Feb 3, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 18, 2022

What does this PR do?

Fixes #11524
Original fix was taken from Lightning-AI/torchmetrics#772

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added the bug Something isn't working label Jan 18, 2022
@Borda Borda added this to the 1.5.x milestone Jan 18, 2022
@Borda Borda requested review from akihironitta and a team January 18, 2022 11:49
@Borda Borda enabled auto-merge (squash) January 18, 2022 11:49
@Borda Borda requested a review from akihironitta January 18, 2022 16:07
pytorch_lightning/utilities/imports.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/imports.py Show resolved Hide resolved
pytorch_lightning/utilities/imports.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jan 18, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton
Copy link
Contributor

tchaton commented Jan 20, 2022

@Borda I think the requires decorator from Lightning Flash by @ethanwharris would also be a great addtion.

@Borda
Copy link
Member Author

Borda commented Jan 20, 2022

@Borda I think the requires decorator from Lightning Flash by @ethanwharris would also be a great addtion.

if whole function or class needs a certain dependency, then yes, but in Flash, in several places, we have a switch inside function/method body... anyway a wrapper is welcome but it is outside of scope of this PR 🐰

@mergify mergify bot added the has conflicts label Feb 3, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
@Borda Borda merged commit c5de105 into master Feb 3, 2022
@Borda Borda deleted the fix/avail-pkgs branch February 3, 2022 03:38
rohitgr7 pushed a commit that referenced this pull request Feb 7, 2022
rohitgr7 pushed a commit that referenced this pull request Feb 8, 2022
lexierule pushed a commit that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import pytorch_lightning fails with ValueError: transformers.models.auto.__spec__ is None
7 participants