-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix available modules #11526
fix available modules #11526
Conversation
Co-authored-by: Carlos Mocholí <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
@Borda I think the |
if whole function or class needs a certain dependency, then yes, but in Flash, in several places, we have a switch inside function/method body... anyway a wrapper is welcome but it is outside of scope of this PR 🐰 |
for more information, see https://pre-commit.ci
What does this PR do?
Fixes #11524
Original fix was taken from Lightning-AI/torchmetrics#772
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda