Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Accelerator inherit from ABC to make sure abstractmethod takes effect #11521

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Let Accelerator inherit from ABC to make sure abstractmethod takes effect #11521

merged 3 commits into from
Jan 23, 2022

Conversation

chunyang-wen
Copy link
Contributor

What does this PR do?

  • We have to inherit from ABC in order to make abstractmethod to take effect. Make Accelerator inherit from ABC
  • Update docstring to better describe the function

@chunyang-wen
Copy link
Contributor Author

The failed test case means that ABC takes effect.

@carmocca carmocca added this to the 1.6 milestone Jan 18, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 18, 2022
ananthsub
ananthsub reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this @chunyang-wen . Could you add an entry to the CHANGELOG since this may be a breaking change for people who write customized accelerator classes and who hadn't implemented the abstract methods?

tchaton
tchaton approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli changed the title Inherit from ABC to make sure abstractmethod takes effect; Modiy comment Inherit from ABC to make sure abstractmethod takes effect Jan 23, 2022
@awaelchli awaelchli changed the title Inherit from ABC to make sure abstractmethod takes effect Inherit Accelerator from ABC to make sure abstractmethod takes effect Jan 23, 2022
@awaelchli awaelchli changed the title Inherit Accelerator from ABC to make sure abstractmethod takes effect Let Accelerator inherit from ABC to make sure abstractmethod takes effect Jan 23, 2022
@awaelchli awaelchli merged commit 350c88e into Lightning-AI:master Jan 23, 2022
@awaelchli
Copy link
Contributor

Thank you for the quick fix @chunyang-wen <3

@chunyang-wen chunyang-wen deleted the inhert-from-ABC branch January 24, 2022 02:17
@chunyang-wen chunyang-wen mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub left review comments

@akihironitta akihironitta akihironitta approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
accelerator code quality ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
8 participants
@chunyang-wen @awaelchli @ananthsub @Borda @carmocca @tchaton @justusschock @akihironitta