Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access to _short_id in NeptuneLogger #11517

Merged
merged 8 commits into from
Jan 20, 2022

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Jan 17, 2022

What does this PR do?

Removes access to the internals of Run in NeptuneLogger (access to run._short_id)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added this to the 1.6 milestone Jan 17, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 18, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot removed the has conflicts label Jan 20, 2022
@Raalsky
Copy link
Contributor Author

Raalsky commented Jan 20, 2022

@awaelchli @carmocca @rohitgr7 @Borda @tchaton Merge? 🙏

@rohitgr7 rohitgr7 enabled auto-merge (squash) January 20, 2022 11:05
@rohitgr7
Copy link
Contributor

@Raalsky

tests are running, it will auto merge now if they pass :)

@rohitgr7 rohitgr7 merged commit e78d658 into Lightning-AI:master Jan 20, 2022
@Raalsky Raalsky deleted the dev/short-id branch January 20, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logger: neptune ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants