Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added warning for distributedsampler in case of evaluation #11479

Merged
merged 15 commits into from
Feb 3, 2022
Merged

added warning for distributedsampler in case of evaluation #11479

merged 15 commits into from
Feb 3, 2022

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

Fixes #11364

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 force-pushed the warn/dist_eval branch 2 times, most recently from a9b12fd to f7200d9 Compare January 14, 2022 15:22
@rohitgr7 rohitgr7 changed the title added warning distributedsampler in case of evaluation added warning for distributedsampler in case of evaluation Jan 14, 2022
@rohitgr7 rohitgr7 added the distributed Generic distributed-related topic label Jan 16, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Jan 16, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review January 16, 2022 17:49
@rohitgr7 rohitgr7 requested a review from carmocca January 18, 2022 10:21
carmocca
carmocca approved these changes Jan 18, 2022
View reviewed changes
pytorch_lightning/trainer/connectors/data_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/data_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/data_connector.py Show resolved Hide resolved
docs/source/common/test_set.rst Outdated Show resolved Hide resolved
tests/trainer/connectors/test_data_connector.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from tchaton January 20, 2022 10:13
@mergify mergify bot added the ready PRs ready to be merged label Jan 20, 2022
awaelchli
awaelchli approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it :)

docs/source/common/test_set.rst Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/data_connector.py Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) January 31, 2022 09:08
@mergify mergify bot added the has conflicts label Feb 3, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
@tchaton tchaton merged commit 4002017 into Lightning-AI:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Add a warning regarding distributed sampling if trainer.test/validate is called under distributed env.
7 participants
@rohitgr7 @awaelchli @Borda @carmocca @tchaton @justusschock @akihironitta