Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Loop.restarting recursively #11442

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Set Loop.restarting recursively #11442

merged 5 commits into from
Jan 14, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 12, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Part of #8578

The PR requires this to fix failing tests. It also makes sense as a standalone feature.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @justusschock @awaelchli @ninginthecloud @ananthsub @rohitgr7

@carmocca carmocca added feature Is an improvement or enhancement fault tolerance loops Related to the Loop API labels Jan 12, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 12, 2022
@carmocca carmocca self-assigned this Jan 12, 2022
@carmocca carmocca marked this pull request as ready for review January 12, 2022 15:47
@mergify mergify bot removed the has conflicts label Jan 13, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 14, 2022
@akihironitta akihironitta enabled auto-merge (squash) January 14, 2022 10:24
@akihironitta akihironitta merged commit 18bbb39 into master Jan 14, 2022
@akihironitta akihironitta deleted the loops/recursively-set-restarting branch January 14, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@akihironitta akihironitta akihironitta approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
fault tolerance feature Is an improvement or enhancement loops Related to the Loop API ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @akihironitta @rohitgr7