Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move progress bar disabling out of the Trainer #11377

Merged
merged 52 commits into from
Feb 3, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Jan 9, 2022

What does this PR do?

Fixes #10982

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz marked this pull request as ready for review January 9, 2022 07:12
@akihironitta akihironitta added this to the 1.6 milestone Jan 9, 2022
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, it no longer seems like enable or disable need to be part of the progress bar callback API, as the trainer no longer directly calls them.

https://github.com/PyTorchLightning/pytorch-lightning/blob/3e0569fccc9808b1017ace63951485e2f76563eb/pytorch_lightning/callbacks/progress/base.py#L139-L154

If that is the case, then we could further streamline the API by not making these required. All progress bar implementations would be required to resolve this themselves, and we can move thie disabling logic out of the base progress bar implementation.

it's similar to what we did with loggers allowing them to log from all ranks, and particular implementations can choose to log from rank 0 only if they wish to.

pytorch_lightning/callbacks/progress/base.py Show resolved Hide resolved
@daniellepintz
Copy link
Contributor Author

tests/checkpointing/test_model_checkpoint.py::test_model_checkpoint_score_and_ckpt[True-False-True-val_log] is failing for some reason on ubuntu, but works in windows environment. Does not seem related to this PR. has anyone else seen this issue before?

@mergify mergify bot removed the has conflicts label Jan 12, 2022
@daniellepintz
Copy link
Contributor Author

@carmocca did you mean to revert the docstring changes here? 578ea1a

@carmocca
Copy link
Contributor

Nope, my bad!

@mergify mergify bot removed the has conflicts label Jan 20, 2022
@awaelchli
Copy link
Contributor

Some investigation has to be done here #11590. I am convinced this PR is affected by this.
To unblock here, we could add pytest-random-order and find a seed that makes the tests pass. That would be fine with me, but on the other hand this PR is not a very high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working progress bar: rich progress bar: tqdm ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move progress bar disabling out of the Trainer
8 participants