-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move progress bar disabling out of the Trainer #11377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up, it no longer seems like enable
or disable
need to be part of the progress bar callback API, as the trainer no longer directly calls them.
If that is the case, then we could further streamline the API by not making these required. All progress bar implementations would be required to resolve this themselves, and we can move thie disabling logic out of the base progress bar implementation.
it's similar to what we did with loggers allowing them to log from all ranks, and particular implementations can choose to log from rank 0 only if they wish to.
|
Nope, my bad! |
Some investigation has to be done here #11590. I am convinced this PR is affected by this. |
What does this PR do?
Fixes #10982
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃