-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent exceptions raised with no rich
installed
#11360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of opening a PR.
This wasn't caught before because these tests don't really run, all jobs seem to install rich
Thanks @akihironitta for looking into this! |
dfcda17
to
995664c
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rich
installedrich
installed
What does this PR do?
Found by @carmocca in #11217.
ModuleNotFoundError
if rich isn't installed or supported version of it isn't installed.Does your PR introduce any breaking changes? If yes, please list them.
ModuleNotFoundError
instead ofMisconfigurationException
whenrich
isn't installed.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @SeanNaren @kaushikb11 @Borda