-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise a warning if evaulation is triggered with best ckpt in case of multiple checkpoint callbacks #11274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 29, 2021 21:04
carmocca
reviewed
Dec 31, 2021
rohitgr7
changed the title
Raise an error if evaulation is triggered with best ckpt in case of multiple checkpoint callbacks
Raise a warning if evaulation is triggered with best ckpt in case of multiple checkpoint callbacks
Jan 3, 2022
awaelchli
approved these changes
Jan 3, 2022
carmocca
reviewed
Jan 3, 2022
rohitgr7
force-pushed
the
ref/best_eval_ckpt
branch
from
January 3, 2022 20:34
a5ca72d
to
e8f50cf
Compare
carmocca
approved these changes
Jan 3, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
for more information, see https://pre-commit.ci
Borda
approved these changes
Jan 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #11274 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 194 194
Lines 16965 16965
=======================================
Hits 15593 15593
Misses 1372 1372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Now that multiple checkpoints are supported, evaluation with the best ckpt cannot be interpreted in such a case. So an error will be raised asking users to specify the exact ckpt path.
Open to better alternatives?
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Part of #1
Make sure you had fun coding 🙃
cc @Borda @awaelchli @rohitgr7