Group metrics generated by DeviceStatsMonitor for better visualization
#11254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
rohitgr7
approved these changes
Dec 24, 2021
ananthsub
changed the title
DeviceStatsMonitor for visualizationDeviceStatsMonitor for better visualization
carmocca
approved these changes
Dec 31, 2021
kaushikb11
approved these changes
Jan 1, 2022
awaelchli
approved these changes
Jan 3, 2022
Borda
approved these changes
Jan 3, 2022
Co-authored-by: Jirka Borovec <[email protected]>
rohitgr7
pushed a commit
that referenced
this pull request
Jan 4, 2022
…ion (#11254) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
| @@ -54,12 +55,15 @@ def on_train_batch_start( | |||
| batch_idx: int, | |||
| unused: Optional[int] = 0, | |||
| ) -> None: | |||
| if not trainer.logger: | |||
| raise MisconfigurationException("Cannot use `DeviceStatsMonitor` callback with `Trainer(logger=False)`.") | |||
There was a problem hiding this comment.
@ananthsub why did you add two more MisconfigurationExceptions here if we already have one in line 48?
There was a problem hiding this comment.
probably because of mypy, which does not know that the logger was already checked against None in the previous hook :))
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11176
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃