-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip testing with PyTorch 1.7 and Python 3.9 on Ubuntu #11217
Conversation
wip |
Looks like it's not the coverage as it still segfaulted. Reading online, this could be useful https://docs.python.org/3/library/faulthandler.html python -X faulthandler -m pytest tests ... |
So the problem was reported already but the fix only made it to 1.8, we'll need to exclude this job parametrization |
@carmocca Thank you very much for taking your time and investigating this! 🎉
I had a look at the GitHub issue before and had it in my mind, but simply running gdb didn't provide such info (i.e. |
Just for the record, this issue seems to have been resolved in #50998 which is included in v1.8.0 as seen in their release note: https://github.com/pytorch/pytorch/releases/tag/v1.8.0 |
This reverts commit e61abc1.
@@ -21,6 +21,9 @@ jobs: | |||
python-version: ["3.7", "3.9"] # minimum, maximum | |||
requires: ["oldest", "latest"] | |||
release: ["stable"] | |||
exclude: | |||
# Skip if torch<1.8 and py3.9 on Linux: https://github.com/pytorch/pytorch/issues/50014 | |||
- {os: ubuntu-18.04, python-version: "3.9", requires: "oldest", release: "stable"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I would not run any oldest for py3.9
- {python-version: "3.9", requires: "oldest"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Borda Could I ask why you wouldn't? This problem shouldn't apply to other oldest settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use release: "stable"
is redundant since we do not have other release values then stable now
and in general, if someone is using almost the latest python I don't think he would assist on the oldest packages...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
release: "stable"
is redundant since we do not have other release values then stable now
👍
in general, if someone is using almost the latest python I don't think he would assist on the oldest packages...
I see your point. I've just created an issue #11367 to gain some visibility on this.
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
What does this PR do?
Fixes #11184.
Skips testing with PyTorch 1.7 and Python 3.9 on Ubuntu due to a known issue with the setting: #11217 (comment)
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda