Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate progress tracking into the progress bar #11213

Merged
merged 15 commits into from
Jan 6, 2022
Merged

Integrate progress tracking into the progress bar #11213

merged 15 commits into from
Jan 6, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 22, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Removes the index increments from the progress bar implementation, instead, relying on the loops' progress tracking.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @justusschock @awaelchli @akihironitta @rohitgr7 @carmocca @ninginthecloud @SeanNaren @kaushikb11 @Borda

@carmocca carmocca added feature Is an improvement or enhancement fault tolerance progress tracking (internal) Related to the progress tracking dataclasses progress bar: rich progress bar: tqdm labels Dec 22, 2021
@carmocca carmocca added this to the 1.6 milestone Dec 22, 2021
@carmocca carmocca self-assigned this Dec 22, 2021
@carmocca carmocca marked this pull request as ready for review December 22, 2021 03:22
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca marked this pull request as draft December 22, 2021 03:47
@carmocca carmocca changed the base branch from master to bugfix/restore-progress-state-after-sanity December 22, 2021 03:52
Base automatically changed from bugfix/restore-progress-state-after-sanity to master December 23, 2021 16:36
@carmocca carmocca mentioned this pull request Dec 23, 2021
Merged
11 tasks
@carmocca carmocca marked this pull request as ready for review December 23, 2021 17:26
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca requested a review from tchaton January 4, 2022 12:32
@carmocca carmocca added refactor and removed feature Is an improvement or enhancement labels Jan 4, 2022
@carmocca carmocca requested review from awaelchli and tchaton January 5, 2022 18:45
@tchaton tchaton mentioned this pull request Jan 6, 2022
Closed
tchaton
tchaton approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jan 6, 2022
@carmocca carmocca merged commit 8a549a5 into master Jan 6, 2022
@carmocca carmocca deleted the ptracking/integrate-pbar branch January 6, 2022 13:29
@carmocca carmocca mentioned this pull request Jan 6, 2022
Merged
9 tasks
@awaelchli awaelchli mentioned this pull request Feb 25, 2022
Merged
12 tasks
@akihironitta akihironitta mentioned this pull request May 30, 2022
Closed
@awaelchli awaelchli mentioned this pull request Jun 29, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
fault tolerance progress bar: rich progress bar: tqdm progress tracking (internal) Related to the progress tracking dataclasses ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @tchaton @rohitgr7