-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid torch amp cuda warning with bf16 on cpu #11161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
bug
Something isn't working
precision: amp
Automatic Mixed Precision
labels
Dec 19, 2021
rohitgr7
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 19, 2021 21:01
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
justusschock
approved these changes
Dec 20, 2021
ananthsub
reviewed
Dec 20, 2021
Co-authored-by: Justus Schock <[email protected]>
awaelchli
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see this being generalized.
ananthsub
approved these changes
Dec 21, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #11161 +/- ##
=======================================
- Coverage 92% 92% -0%
=======================================
Files 177 177
Lines 16556 16554 -2
=======================================
- Hits 15223 15213 -10
- Misses 1333 1341 +8 |
SeanNaren
approved these changes
Dec 21, 2021
rohitgr7
added a commit
that referenced
this pull request
Dec 21, 2021
Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
rohitgr7
added a commit
that referenced
this pull request
Dec 21, 2021
Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Dec 21, 2021
Co-authored-by: Justus Schock <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use precision_plugin context manager to avoid following warning with bf16 on CPU.
UserWarning: User provided device_type of 'cuda', but CUDA is not available. Disabling
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
Part of #1
cc @Borda @carmocca @justusschock @awaelchli @akihironitta