Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid torch amp cuda warning with bf16 on cpu #11161

Merged
merged 5 commits into from
Dec 21, 2021
Merged

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Dec 19, 2021

What does this PR do?

Use precision_plugin context manager to avoid following warning with bf16 on CPU.

UserWarning: User provided device_type of 'cuda', but CUDA is not available. Disabling

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Part of #1

cc @Borda @carmocca @justusschock @awaelchli @akihironitta

@rohitgr7 rohitgr7 added bug Something isn't working precision: amp Automatic Mixed Precision labels Dec 19, 2021
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Dec 19, 2021
@rohitgr7 rohitgr7 self-assigned this Dec 19, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review December 19, 2021 21:01
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from ananthsub December 20, 2021 20:49
Co-authored-by: Justus Schock <[email protected]>
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see this being generalized.

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #11161 (16ebbc6) into master (7ed3dbf) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #11161   +/-   ##
=======================================
- Coverage      92%      92%   -0%     
=======================================
  Files         177      177           
  Lines       16556    16554    -2     
=======================================
- Hits        15223    15213   -10     
- Misses       1333     1341    +8     

@rohitgr7 rohitgr7 merged commit 93ce2d7 into master Dec 21, 2021
@rohitgr7 rohitgr7 deleted the fix/autocast_cpu_warn branch December 21, 2021 12:54
rohitgr7 added a commit that referenced this pull request Dec 21, 2021
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
rohitgr7 added a commit that referenced this pull request Dec 21, 2021
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
lexierule pushed a commit that referenced this pull request Dec 21, 2021
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working precision: amp Automatic Mixed Precision ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants