Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TrainerCallbackHookMixin #11148

Merged
merged 11 commits into from
Dec 21, 2021

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Dec 18, 2021

What does this PR do?

In #10575 I removed many methods of TrainerCallbackHookMixin, but we should keep them for BC until v1.8 so that Trainer.call_hook still works as it did before, i.e. if someone calls Trainer.call_hook("on_before_accelerator_backend_setup") that should still work.

This PR puts back the methods removed in #10575, and then deprecates the entire TrainerCallbackHookMixin class.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added deprecation Includes a deprecation trainer labels Dec 18, 2021
@awaelchli awaelchli added this to the 1.6 milestone Dec 18, 2021
pytorch_lightning/trainer/callback_hook.py Outdated Show resolved Hide resolved
tests/deprecated_api/test_remove_1-7.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/callback_hook.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@daniellepintz daniellepintz changed the title Put back methods in TrainerCallbackHookMixin for BC Deprecate TrainerCallbackHookMixin Dec 19, 2021
@daniellepintz daniellepintz marked this pull request as draft December 19, 2021 23:43
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda
Copy link
Member

Borda commented Dec 21, 2021

still draft?

@daniellepintz
Copy link
Contributor Author

@Borda I am waiting for #11179 to be merged first

@daniellepintz daniellepintz marked this pull request as ready for review December 21, 2021 16:52
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2021
@daniellepintz
Copy link
Contributor Author

daniellepintz commented Dec 21, 2021

Ready to be merged!

@ananthsub ananthsub merged commit ac8dc2c into Lightning-AI:master Dec 21, 2021
@daniellepintz daniellepintz deleted the deprecate_mixin branch December 21, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Includes a deprecation ready PRs ready to be merged trainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants