-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TrainerCallbackHookMixin
#11148
Merged
ananthsub
merged 11 commits into
Lightning-AI:master
from
daniellepintz:deprecate_mixin
Dec 21, 2021
Merged
Deprecate TrainerCallbackHookMixin
#11148
ananthsub
merged 11 commits into
Lightning-AI:master
from
daniellepintz:deprecate_mixin
Dec 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellepintz
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 18, 2021 01:04
ananthsub
reviewed
Dec 18, 2021
awaelchli
approved these changes
Dec 18, 2021
ananthsub
reviewed
Dec 19, 2021
ananthsub
reviewed
Dec 19, 2021
daniellepintz
changed the title
Put back methods in TrainerCallbackHookMixin for BC
Deprecate Dec 19, 2021
TrainerCallbackHookMixin
tchaton
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Merged
12 tasks
for more information, see https://pre-commit.ci
…ghtning into deprecate_mixin
still draft? |
ananthsub
approved these changes
Dec 21, 2021
Ready to be merged! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #10575 I removed many methods of
TrainerCallbackHookMixin
, but we should keep them for BC until v1.8 so thatTrainer.call_hook
still works as it did before, i.e. if someone callsTrainer.call_hook("on_before_accelerator_backend_setup")
that should still work.This PR puts back the methods removed in #10575, and then deprecates the entire
TrainerCallbackHookMixin
class.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃