Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluation logging on epoch end with multiple dataloaders #11132

Merged
merged 6 commits into from
Dec 19, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 17, 2021

What does this PR do?

Fixes #10904

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @edward-io @ananthsub

@carmocca carmocca added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Dec 17, 2021
@carmocca carmocca added this to the 1.6 milestone Dec 17, 2021
@carmocca carmocca self-assigned this Dec 17, 2021
@carmocca carmocca force-pushed the bugfix/log-multi-dl-epoch-end branch from 7138249 to 6517021 Compare December 17, 2021 19:59
@carmocca carmocca changed the title [WIP] Fix evaluation logging on epoch end with multiple dataloaders Fix evaluation logging on epoch end with multiple dataloaders Dec 17, 2021
@carmocca carmocca marked this pull request as ready for review December 17, 2021 20:14
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Dec 17, 2021
@carmocca carmocca enabled auto-merge (squash) December 17, 2021 21:19
@carmocca carmocca merged commit 7ed3dbf into master Dec 19, 2021
@carmocca carmocca deleted the bugfix/log-multi-dl-epoch-end branch December 19, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging does not work on evaluation epoch end with multiple dataloaders
4 participants