Reset the current progress tracking state during double evaluation

[carmocca]

What does this PR do?

With fault-tolerance disabled, the following runs twice through the test set, it's equivalent to max_test_epochs=2

trainer = Trainer(...)
trainer.test(...)
trainer.test(...)

However, currently in master, if fault-tolerance is enabled, the second test exits early. This is because the done condition for the test loop has been already fulfilled:

self.dataloader_progress.current.completed >= self.num_dataloaders

To avoid this, we need to check whether we are NOT fitting, and whether the previous state is done, then in that case reset the state.

This is different from how fit works where this is the expected behavior and the user is required to set a different max_epochs value. The equivalent would be that the user has to change self.num_dataloaders which does not make sense.

Predict also has this bug, but there we don't need the fit check.

Test plan

This is covered by existing tests, for example: test_checkpoint_path_input

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

• [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• [n/a] Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @justusschock @awaelchli @ninginthecloud @Borda

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[tchaton]

LGTM !