Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3/n Move accelerator into Strategy #11022

Merged
merged 42 commits into from
Dec 16, 2021
Merged

3/n Move accelerator into Strategy #11022

merged 42 commits into from
Dec 16, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Dec 10, 2021 •
edited
Loading

What does this PR do?

Last step of Move accelerator into Strategy

Fixes #10648

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish marked this pull request as draft December 10, 2021 00:43
@ananthsub ananthsub mentioned this pull request Dec 10, 2021
Closed
@four4fish four4fish force-pushed the move-accelerator branch 3 times, most recently from 7b83f85 to 2e35731 Compare December 10, 2021 23:43
@four4fish four4fish added this to the 1.6 milestone Dec 10, 2021
@four4fish four4fish linked an issue Dec 10, 2021 that may be closed by this pull request
[Accelerator refactor] Move Accelerator into Strategy #10648
Closed
@four4fish four4fish changed the title Move accelerator into Strategy [co-author with Adrian] 3/n Move accelerator into Strategy [co-author with Adrian] Dec 10, 2021
@four4fish four4fish marked this pull request as ready for review December 11, 2021 01:28
ananthsub
ananthsub reviewed Dec 11, 2021
View reviewed changes
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: updating references for trainer.accelerator.training_type_plugin to trainer.training_type_plugin ((e.g. in files test_deepspeed_plugin and test_ddp_plugin_wih_comm_hook) could be a separate PR to make this one smaller and easier to review

pytorch_lightning/accelerators/gpu.py Show resolved Hide resolved
pytorch_lightning/accelerators/tpu.py Show resolved Hide resolved
pre-commit-ci bot and others added 26 commits December 15, 2021 20:10
@pre-commit-ci @four4fish
[pre-commit.ci] auto fixes from pre-commit.com hooks
34b9544 
for more information, see https://pre-commit.ci
@four4fish
fix tpu error check
46283e2
@pre-commit-ci @four4fish
[pre-commit.ci] auto fixes from pre-commit.com hooks
e6dfafe 
for more information, see https://pre-commit.ci
@four4fish
fix precision_plugin initialization to recognisze cusomized plugin
347a4f1
@pre-commit-ci @four4fish
[pre-commit.ci] auto fixes from pre-commit.com hooks
c0120d0 
for more information, see https://pre-commit.ci
@four4fish
Update bug_report_model.py
f08163b
@four4fish
Update accelerator_connector.py
34c13ff
@awaelchli @four4fish
update changelog
6bdb464
@awaelchli @four4fish
allow shorthand typing references to pl.Accelerator
c039c68
@awaelchli @four4fish
rename helper method and add docstring
0976c50
@awaelchli @four4fish
fix typing
7b1738c
@awaelchli @carmocca @four4fish
Update pytorch_lightning/trainer/connectors/accelerator_connector.py
2f18893 
Co-authored-by: Carlos Mocholí <[email protected]>
@awaelchli @carmocca @four4fish
Update tests/accelerators/test_accelerator_connector.py
bf97a58 
Co-authored-by: Carlos Mocholí <[email protected]>
@awaelchli @carmocca @four4fish
Update tests/accelerators/test_cpu.py
e0f4a77 
Co-authored-by: Carlos Mocholí <[email protected]>
@pre-commit-ci @four4fish
[pre-commit.ci] auto fixes from pre-commit.com hooks
5488519 
for more information, see https://pre-commit.ci
@awaelchli @four4fish
fix pre commit complaint
b69537e
@awaelchli @four4fish
update typing to long ugly path
94fe8f8
@awaelchli @four4fish
spacing in flow diagram
19bcf3f
@four4fish
remove todo comments
5862afe
@awaelchli @four4fish
docformatter
2dfc443
@awaelchli @four4fish
Update pytorch_lightning/plugins/training_type/training_type_plugin.py
92cc262
@four4fish
revert test changes
ff3e2dc
@four4fish
improve custom plugin examples
9f1eade
@awaelchli @four4fish
remove redundant call to ttp attribute
a74f4c1 
it is no longer a property
@pre-commit-ci @four4fish
[pre-commit.ci] auto fixes from pre-commit.com hooks
292c640 
for more information, see https://pre-commit.ci
@four4fish @carmocca
Apply suggestions from code review
448b524 
Co-authored-by: Carlos Mocholí <[email protected]>
@four4fish four4fish enabled auto-merge (squash) December 16, 2021 04:11
@four4fish four4fish merged commit cec2d79 into Lightning-AI:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
accelerator breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[Accelerator refactor] Move Accelerator into Strategy
5 participants
@four4fish @ananthsub @awaelchli @carmocca @justusschock