Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _call_accelerator_hook Trainer method #10999

Merged

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Dec 8, 2021

What does this PR do?

After #10890 we only have one remaining usage of _call_accelerator_hook. We can remove this call by moving the line torch.cuda.empty_cache() from on_train_start to setup in accelerators/gpu.py. Then we can remove the _call_accelerator_hook Trainer method entirely.

fix #10905

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@four4fish four4fish added the breaking change Includes a breaking change label Dec 8, 2021
@daniellepintz
Copy link
Contributor Author

@four4fish why is this a breaking change? It doesn't affect users

@four4fish
Copy link
Contributor

@four4fish why is this a breaking change? It doesn't affect users

for customized accelerator user who may override this function

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please be sure to fill out the checklist (especially filling out a changelog entry) before this is merged

@mergify mergify bot added the ready PRs ready to be merged label Dec 8, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@ananthsub ananthsub added this to the 1.6 milestone Dec 8, 2021
@awaelchli awaelchli merged commit 3fcfd02 into Lightning-AI:master Dec 9, 2021
@daniellepintz daniellepintz deleted the dep_call_accelerator_hook branch December 9, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: cuda Compute Unified Device Architecture GPU accelerator breaking change Includes a breaking change ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove _call_accelerator_hook after move accelerator into strategy
5 participants